New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(firebase_app_check): provide androidDebugProvider
boolean for android debug provider & update app check example app
#9412
Merged
+91
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
russellwheatley
added
platform: android
Issues / PRs which are specifically for Android.
plugin: app_check
labels
Aug 24, 2022
# Conflicts: # packages/firebase_app_check/firebase_app_check/android/src/main/java/io/flutter/plugins/firebase/appcheck/FlutterFirebaseAppCheckPlugin.java
russellwheatley
commented
Sep 6, 2022
...ndroid/src/main/java/io/flutter/plugins/firebase/appcheck/FlutterFirebaseAppCheckPlugin.java
Outdated
Show resolved
Hide resolved
10 tasks
russellwheatley
changed the title
chore(firebase_app_check): Update example app and android configuration for debug testing
feat(firebase_app_check): "androidDebugProvider" API for Sep 12, 2022
activate()
for testing purposes & update app check example app
russellwheatley
changed the title
feat(firebase_app_check): "androidDebugProvider" API for
feat(firebase_app_check): provide Sep 12, 2022
activate()
for testing purposes & update app check example appandroidDebugProvider
boolean for android testing & update app check example app
russellwheatley
changed the title
feat(firebase_app_check): provide
feat(firebase_app_check): provide Sep 12, 2022
androidDebugProvider
boolean for android testing & update app check example appandroidDebugProvider
boolean for android debug provider & update app check example app
We probably should look to create an option for users to choose between the two different android providers as well (Safety Net and Play Integrity) which this PR attempted to implement |
…ussell/app-check-6551
Lyokone
approved these changes
Sep 27, 2022
Salakar
approved these changes
Sep 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Blocks App check debug documentation which will be merged once this PR is merged.
Related Issues
closes #6551
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
).This will ensure a smooth and quick review process. Updating the
pubspec.yaml
and changelogs is not required.///
).melos run analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?